chore(gonf): fix go vet and staticcheck errors

pkg/custom.go

@@ -31,7 +31,7 @@ func (c *CustomPromise) Resolve() {
 }
 
 func (c CustomPromise) Status() Status {
-	return c.Status()
+	return c.promise.Status()
 }
 
 func resolveCustomPromises() (status Status) {

pkg/packages.go

@@ -7,7 +7,6 @@ var packages []*PackagePromise
 
 // packages management functions
 var packages_install_function func([]string) (Status, []string)
-var packages_update_function *CommandPromise
 
 // ----- Init ------------------------------------------------------------------
 func init() {
@@ -17,7 +16,6 @@ func init() {
 // ----- Public ----------------------------------------------------------------
 func SetPackagesConfiguration(install func([]string) (Status, []string), update *CommandPromise) {
 	packages_install_function = install
-	packages_update_function = update
 }
 
 func Package(names ...string) *PackagePromise {

pkg/permissions.go

@@ -75,7 +75,7 @@ func (p *Permissions) resolve(filename string) (Status, error) {
 				status = REPAIRED
 			}
 		} else {
-			return BROKEN, errors.New("Unsupported operating system")
+			return BROKEN, errors.New("unsupported operating system")
 		}
 	}
 	return status, nil

pkg/triggers.go

@@ -1,11 +0,0 @@
-package gonf
-
-type simpleTrigger struct {
-	fact   string
-	status Status
-}
-
-//type compositeTrigger struct {
-//	triggers  []simpleTrigger
-//	operation Operation
-//}

pkg/values.go

@@ -68,13 +68,13 @@ type IntValue struct {
 }
 
 func (i IntValue) Bytes() []byte {
-	return []byte(string(i.value))
+	return []byte(fmt.Sprint(i.value))
 }
 func (i IntValue) Int() (int, error) {
 	return i.value, nil
 }
 func (i IntValue) String() string {
-	return string(i.value)
+	return fmt.Sprint(i.value)
 }
 
 // ----- StringsListValue ------------------------------------------------------

stdlib/os/systemd/systemd.go

@@ -66,5 +66,4 @@ func systemd_service(name, state string) (gonf.Status, error) {
 	default:
 		return gonf.BROKEN, errors.New("unsupported systemctl operation " + state)
 	}
-	return gonf.KEPT, nil
 }