Moved isIn function to a util file

This commit is contained in:
Julien Dessaux 2021-09-19 01:10:52 +02:00
parent 2ba8d90815
commit 0c52da6714
4 changed files with 48 additions and 39 deletions

View file

@ -2,19 +2,15 @@ package field
func (f Field) Step(x, y, dx, dy int) (int, int) { func (f Field) Step(x, y, dx, dy int) (int, int) {
x2, y2 := x+dx, y+dy x2, y2 := x+dx, y+dy
if f.IsIn(x2, y2) { if f.isIn(x2, y2) {
return x2, y2 return x2, y2
} }
// We are stepping outside, we need to wrap the Lahey-space // We are stepping outside, we need to wrap the Lahey-space
for { for {
x2, y2 := x-dx, y-dy x2, y2 := x-dx, y-dy
if !f.IsIn(x2, y2) { if !f.isIn(x2, y2) {
return x, y return x, y
} }
x, y = x2, y2 x, y = x2, y2
} }
} }
func (f Field) IsIn(x, y int) bool {
return x >= f.x && x < f.x+f.lx && y >= f.y && y < f.y+f.ly
}

View file

@ -40,36 +40,3 @@ func TestStep(t *testing.T) {
}) })
} }
} }
func TestIsIn(t *testing.T) {
// Test cases
testCases := []struct {
name string
input string
inputX int
inputY int
expected bool
}{
{"minimal0,0", "test_data/minimal.b98", 0, 0, true},
{"minimal-1,0", "test_data/minimal.b98", -1, 0, false},
{"minimal1,0", "test_data/minimal.b98", 1, 0, false},
{"minimal0,-1", "test_data/minimal.b98", 0, -1, false},
{"minimal0,1", "test_data/minimal.b98", 0, 1, false},
{"hello3,0", "test_data/hello.b98", 3, 0, true},
{"hello3,1", "test_data/hello.b98", 3, 1, false},
{"factorial0,1", "test_data/factorial.b98", 0, 1, true},
{"factorial14,1", "test_data/factorial.b98", 14, 1, true},
{"factorial15,1", "test_data/factorial.b98", 15, 1, false},
}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
file, err := os.Open(tc.input)
require.NoError(t, err, "Failed to open file")
defer file.Close()
field, err := LoadFile(file)
valid := field.IsIn(tc.inputX, tc.inputY)
require.NoError(t, err)
require.Equal(t, tc.expected, valid, "Invalid value")
})
}
}

5
pkg/field/utils.go Normal file
View file

@ -0,0 +1,5 @@
package field
func (f Field) isIn(x, y int) bool {
return x >= f.x && x < f.x+f.lx && y >= f.y && y < f.y+f.ly
}

41
pkg/field/utils_test.go Normal file
View file

@ -0,0 +1,41 @@
package field
import (
"os"
"testing"
"github.com/stretchr/testify/require"
)
func TestIsIn(t *testing.T) {
// Test cases
testCases := []struct {
name string
input string
inputX int
inputY int
expected bool
}{
{"minimal0,0", "test_data/minimal.b98", 0, 0, true},
{"minimal-1,0", "test_data/minimal.b98", -1, 0, false},
{"minimal1,0", "test_data/minimal.b98", 1, 0, false},
{"minimal0,-1", "test_data/minimal.b98", 0, -1, false},
{"minimal0,1", "test_data/minimal.b98", 0, 1, false},
{"hello3,0", "test_data/hello.b98", 3, 0, true},
{"hello3,1", "test_data/hello.b98", 3, 1, false},
{"factorial0,1", "test_data/factorial.b98", 0, 1, true},
{"factorial14,1", "test_data/factorial.b98", 14, 1, true},
{"factorial15,1", "test_data/factorial.b98", 15, 1, false},
}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
file, err := os.Open(tc.input)
require.NoError(t, err, "Failed to open file")
defer file.Close()
field, err := LoadFile(file)
valid := field.isIn(tc.inputX, tc.inputY)
require.NoError(t, err)
require.Equal(t, tc.expected, valid, "Invalid value")
})
}
}