adyxax/bareos-zabbix-check
1
0
Fork 0
Code Issues Activity

Added tests to the main package and completely reworked the code around that

Browse source
This commit is contained in:
Julien Dessaux 2020-02-24 23:05:45 +01:00
parent 2661ce9a2b
commit cadb15f7af
17 changed files with 285 additions and 239 deletions
Download patch file Download diff file Expand all files Collapse all files

56
zabbix/main_test.go Normal file
View file

@ -0,0 +1,56 @@
package zabbix
import (
"flag"
"os"
"path/filepath"
"testing"
)
func TestMain(t *testing.T) {
os.RemoveAll("tmp")
cwd, _ := os.Getwd()
err := os.MkdirAll("tmp/ok-18.2", 0777)
if err != nil {
t.Skipf("skipping main tests because tmp directory cannot be created : %s", err)
}
os.MkdirAll("tmp/ok-17.2", 0777)
os.MkdirAll("tmp/no_state_file", 0777)
os.MkdirAll("tmp/bacula_auto_detect_failed/var/lib/bacula", 0777)
os.MkdirAll("tmp/bareos_auto_detect_failed/var/lib/bareos", 0777)
os.MkdirAll("tmp/error", 0777)
os.Symlink("../../testdata/bareos-fd-17.2.state", "tmp/ok-17.2/state")
os.Symlink("../../testdata/bareos-fd-18.2.state", "tmp/ok-18.2/state")
os.Symlink("../../testdata/bareos-fd-18.2.state-with-error", "tmp/error/state")
tests := []struct {
name string
timestamp uint64
rootDir string
args []string
want string
}{
{"failed bacula_auto_detect", 0, "tmp/bacula_auto_detect_failed", []string{}, "INFO Failed to init programm : Could not find a suitable state file. Has a job ever run?"},
{"failed bareos_auto_detect", 0, "tmp/bareos_auto_detect_failed", []string{}, "INFO Failed to init programm : Could not find a suitable state file. Has a job ever run?"},
{"failed auto_detect", 0, "tmp/non_existent", []string{}, "INFO Failed to init programm : Could not find a suitable work directory. Is bareos or bacula installed?"},
{"no work directory", 0, "tmp", []string{"-w", "/non_existent"}, "INFO Failed to init programm : Invalid work directory /home/julien/git/awh/bareos-zabbix-check/zabbix/tmp/non_existent : it does not exist or is not a directory"},
{"no state file auto_detect", 0, "tmp", []string{"-w", "/no_state_file"}, "INFO Failed to init programm : Could not find a suitable state file. Has a job ever run?"},
{"no state file", 0, "tmp", []string{"-w", "/no_state_file", "-f", "test"}, "INFO Failed to init programm : The state file /home/julien/git/awh/bareos-zabbix-check/zabbix/tmp/no_state_file/test does not exist"},
{"ok bareos 18.2", 1582579731, "tmp/ok-18.2", []string{"-w", "/", "-f", "state"}, "OK"},
{"ok bareos 17.2", 1582579731, "tmp/ok-17.2", []string{"-w", "/", "-f", "state"}, "OK"},
{"missing", 1582709331, "tmp/ok-18.2", []string{"-w", "/", "-f", "state"}, "AVERAGE: missing: awhphpipam1_percona_xtrabackup, awhphpipam1_LinuxAll, awhphpipam1_www"},
{"error", 1582579731, "tmp/error", []string{"-w", "/", "-f", "state"}, "AVERAGE: errors: awhphpipam1_percona_xtrabackup, awhphpipam1_www Corrupted spool file: invalid argument"},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
now = tt.timestamp
root = filepath.Join(cwd, tt.rootDir)
flag.CommandLine = flag.NewFlagSet("bareos-zabbix-check", flag.ExitOnError) //flags are now reset
os.Args = append([]string{"bareos-zabbix-check"}, tt.args...)
if got := Main(); got != tt.want {
t.Log(workDir)
t.Errorf("Main() = %v, want %v", got, tt.want)
}
})
}
os.RemoveAll("tmp")
}