From 3410caa6f2e1fd74d55f7a1717420bb2e1052b12 Mon Sep 17 00:00:00 2001
From: Julien Dessaux
Date: Sat, 29 May 2010 23:48:47 +0200
Subject: Fixed the plugin termination.

The master of a plugin will now wait for the plugin it kills to terminate.
---
 Hsbot/Irc/Plugin.hs | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

(limited to 'Hsbot/Irc/Plugin.hs')

diff --git a/Hsbot/Irc/Plugin.hs b/Hsbot/Irc/Plugin.hs
index 28026aa..2c8e84b 100644
--- a/Hsbot/Irc/Plugin.hs
+++ b/Hsbot/Irc/Plugin.hs
@@ -52,11 +52,12 @@ loadIrcPlugin pluginName = do
     case M.lookup pluginName oldPlugins of
         Just _  -> return ()
         Nothing -> do
-            threadId <- liftIO $ forkIO (entryPoint pluginChan masterChan)
+            mvar <- liftIO newEmptyMVar
+            threadId <- liftIO . forkIO $ finally (entryPoint pluginChan masterChan) (putMVar mvar ())
             let plugin        = IrcPluginState { ircPluginName       = pluginName
                                                , ircPluginChan       = pluginChan
                                                , ircPluginMasterChan = masterChan }
-                newPlugins    = M.insert pluginName (plugin, threadId) oldPlugins
+                newPlugins    = M.insert pluginName (plugin, mvar, threadId) oldPlugins
                 newResumeData = M.insert "PLUGINS" (show $ M.keys newPlugins) oldResumeData
             put $ ircbot { ircBotPlugins    = newPlugins
                          , ircBotResumeData = newResumeData }
@@ -67,7 +68,7 @@ listPlugins originalRequest dest = do
     plugins <- gets ircBotPlugins
     let listing = unwords $ M.keys plugins
     case M.lookup dest plugins of
-        Just (plugin, _) -> sendToPlugin (IntIrcCmd $ IrcCmd "ANSWER" "CORE" dest listing originalRequest) plugin
+        Just (plugin, _, _) -> sendToPlugin (IntIrcCmd $ IrcCmd "ANSWER" "CORE" dest listing originalRequest) plugin
         Nothing          -> return ()
 
 -- | Unloads a plugin
@@ -87,9 +88,10 @@ killIrcPlugin name = do
     let oldPlugins = ircBotPlugins ircbot
     -- We check if the plugin exists
     case M.lookup name oldPlugins of
-        Just (_, threadId) -> do
+        Just (_, mvar, threadId) -> do
             let newPlugins = M.delete name oldPlugins
             liftIO $ throwTo threadId UserInterrupt
             put $ ircbot { ircBotPlugins = newPlugins }
+            liftIO $ takeMVar mvar
         Nothing            -> return ()
 
-- 
cgit v1.2.3